feat: add book module #2949
feat: add book module #2949
Conversation
✅ Deploy Preview for fakerjs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #2949 +/- ##
==========================================
- Coverage 99.96% 99.96% -0.01%
==========================================
Files 2778 2794 +16
Lines 226364 227415 +1051
Branches 577 575 -2
==========================================
+ Hits 226288 227333 +1045
- Misses 76 82 +6
|
ST-DDT
added
s: accepted
cieslarmichal
dismissed stale reviews from import-brain, Shinigami92, ST-DDT, and matthewmayer
via
272e259
|
I have just added more book titles and authors (about 150 each). |
cieslarmichal
requested review from
matthewmayer,
ST-DDT,
import-brain and
Shinigami92
There was a problem hiding this comment.
I'll already approve. I still have the question if the addition of the polish locale should be it's own PR. That way there would be a separate entry on our reloase notes/changelog.
- Create book module (new modules have to have applicable locale data in the default locale => en)
- Add polish locale data for book module.
This is not blocking. Just a question on the process.
Edit: Also, thank you @cieslarmichal for the initial waiting, quick implementation and reasonable feedback loops. Was a pleasure reviewing your PR.
Initial data is initial data. |
|
I would say if it's only 2 or 3 locales included it's better to include in the initial commit. That helps verify there are no incorrect assumptions about how the data will be localised (for example in the first version of this PR the pl and en versions of author used different FirstName surname orders. That was good, as it helped us clarify what the rule should be in general and standardise it.) |
|
Thank you guys for a nice word :) It was a good review process, I am happy about it, can't wait to release those changes 😎 |
|
Dear @cieslarmichal, Thank you for your patience and contributions so far. We wanted to provide you with a brief update. We are pleased to inform you that we have addressed all the known bugs in version 9.0. We will now take a short break and resume work around October 7, 2024, to begin merging new features for v9.1, including yours. In the meantime, we hope you have a great time, and we sincerely appreciate your ongoing support and contributions. Best regards, |
|
Hello, thank you for giving me a chance to contribute and for the information about expected release date 💪 |
Added new Book module as discussed in #2310.
Changes made: